-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
118 log transform yi #121
Merged
Merged
118 log transform yi #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- equivalent to `pred_to_z()` - #102 write documentation
- #102 add import, return, and see also roxygen doc tags, replace note with details tag, rename fn doc title - #116 update argument checks conditional expression - #118 match output to `log_transform_yi()` (now returns additional cols `lower` and `upper`, not only `c("Z","VZ")`) - #118 match process to `log_transform_yi()` and #97 generalise processing to both euc/bt datasets without hard-coding dataset names in fns, and remove associated dataset-specific argument checking #116
- #116 check appropriate required variable (i.e. function needs `back_transformed_data`, but checked for `augmented_data` in `dat` arg, wouldn't throw required error because `augmented_data` was present in `dat`
…dardisation updates - #118 extract `lower` and `upper` transformed vals in line with addition of `log_transform_response()` / changes to `standardise_response()`
…pipeline - #118 call new arg `dataset_log_transform` in fn to log-transform outcomes for euc yi analysis
…lied for standardising / transformation - accidentally deleted when upgrading for #118, have added creation of transform_datasets tibbles for all cases now, and then these will apply the appropriate functions in final code chunk at end
- `dat` to `data` to help with auto-matching in pmap within prepare_response_variables() wrapper #118 - ensure all family fns have ... arg for pmap application in prepare_response_variables() since all fns have different argument lengths and names
…ample code for `log_transform_response()`
… of transformation / standardisation in `standardise_response()` - #118 delete old pmap helper function
egouldo
added
bug
an unexpected problem or unintended behavior
documentation
feature
a feature request or enhancement
breaking change ☠️
API change likely to affect existing code
upkeep
maintenance, infrastructure, and similar
labels
Aug 28, 2024
CodeFactor found an issue: Put a space after a comma. It's currently on: |
CodeFactor found multiple issues last seen at 79be4c8: Add a terminal newline. |
egouldo
commented
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check listing and make suggestions
This was referenced Aug 28, 2024
egouldo
added a commit
that referenced
this pull request
Aug 29, 2024
was originally only included to generate hard-coded columns, now no longer needed with #121 / #130 updates, and was never planned: <https://egouldo.github.io/ManyAnalysts/#out-of-sample-predictions-y_i-2>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ☠️
API change likely to affect existing code
bug
an unexpected problem or unintended behavior
documentation
feature
a feature request or enhancement
upkeep
maintenance, infrastructure, and similar
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_transform()
inprepare_response_variables()
log_transform_yi()
prepare_response_variables()
- Log-transform yi estimates prior to fitting MA mod #118 adapt response variable preparation to accept additional argumentdataset_log_transform
apply argument checks Defensive programming / argument checks #116, add roxygen param roxygen2 documentation for all functions #102 - Log-transform yi estimates prior to fitting MA mod #118 adapt response variable processing to accept either/or/none for dataset standardisation/log-transformation.pred_toZ()
standardise_response()
process_response()
to match log-transformation and standardisation updateslog_transform_response()
prepare_response_variables()
in targets pipeline.x
arg with.y
arg inmap2()
calldat
todata
to help with auto-matching in pmap within prepare_response_variables() wrapper Log-transform yi estimates prior to fitting MA mod #118 - ensure all family fns have ... arg for pmap application in prepare_response_variables() since all fns have different argument lengths and namesstandardise_response()
and update example code forlog_transform_response()
standardise_response()
- Log-transform yi estimates prior to fitting MA mod #118 delete old pmap helper functionestimate_type
is missing inManyEcoEvo
dataframe - Log-transform yi estimates prior to fitting MA mod #118 build: devtools::document()exclude_extreme_VZ()
to allow differencVZ
colnames (i.e. fromlog_transform_response()
) Log-transform yi estimates prior to fitting MA mod #118 - refactor!:apply_VZ_exclusions()
to handle different out-of-sample colnames for each dataset Log-transform yi estimates prior to fitting MA mod #118apply_VZ_exclusions()
after 02d058e Log-transform yi estimates prior to fitting MA mod #118devtools::document()
Log-transform yi estimates prior to fitting MA mod #118 Upkeep for ManyEcoEvo (2024) #97@family
tag Log-transform yi estimates prior to fitting MA mod #118 anddevtools::document()
out
and returnpointblank::
column checks and user warnings Defensive programming / argument checks #116pointblank::cars()
withc()
since is superceded and add arg checking Defensive programming / argument checks #116.data
generate_outlier_subsets()
cli
braces in calls toglue::glue
, switch toc()
Zr
case (i.e. whenestimate_type
is supplied).by =
arg on joins docs: Add@details
and @import` tags*cli
expressions, rm improper use ofglue::glue()
Upkeep for ManyEcoEvo (2024) #97 bug!: Log-transform yi estimates prior to fitting MA mod #118 ensureestimate_type
column is added back in using argument value if existing col is replaced and stop grouping on returned data frame@imports
Upkeep for ManyEcoEvo (2024) #97 roxygen2 documentation for all functions #102poss_fit_sorensen_glm()
devtools::document()
meta_analyse_datasets()
post-Log-transform yi estimates prior to fitting MA mod #118 updatesdevtools::document()
@imports
roxygen2 documentation for all functions #102 - style: use comments to structure function. rearrange condition checks, and helper functions. update indentation. Upkeep for ManyEcoEvo (2024) #97@import*
calls style: fix indentation and spacing Upkeep for ManyEcoEvo (2024) #97@import
tags style: fix indentation, spacing, reorganise subsectionsdevtools::document()
roxygen2 documentation for all functions #102renv::snapshot()
targets::tar_make()