Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure outlier removal is also run on exclusion_set == "partial" #144

Closed
egouldo opened this issue Sep 2, 2024 · 0 comments · Fixed by #148
Closed

Ensure outlier removal is also run on exclusion_set == "partial" #144

egouldo opened this issue Sep 2, 2024 · 0 comments · Fixed by #148
Assignees
Labels
bug an unexpected problem or unintended behavior

Comments

@egouldo
Copy link
Owner

egouldo commented Sep 2, 2024

Manuscript text in SM2 describes this running on partial as well.

image

@egouldo egouldo added the bug an unexpected problem or unintended behavior label Sep 2, 2024
@egouldo egouldo added this to the Respond Reviewer Comments milestone Sep 2, 2024
@egouldo egouldo self-assigned this Sep 2, 2024
egouldo added a commit that referenced this issue Sep 3, 2024
…ues in Zr #144

removed filter for `exclusion_set` == "complete"
egouldo added a commit that referenced this issue Sep 5, 2024
* Increment version number to 2.7.5.9000

* bug: fix threshold checking for multivariate model fitting #147

only count `mixed_model` after calling `distinct()` on analysis identifier column and `mixed_model` first.

Update argument checking to fail if any id columns not present.

docs: update `@details` section about required id column and add `any_of()` to `@importFrom`

* docs: rearrange headings in NEWS.md

* bug: ensure outlier subset creation occurs on all `exclusion_set` values in Zr #144

removed filter for `exclusion_set` == "complete"

* bug: exclude analysis with non-count-based dependent variable from `yi` analysis #145

* feat: #146 add function for excluding extreme estimates based on a multiplier threshold for population parameter estimates

* fix typo #146

* docs!: #146 `devtools::document()`

* bug: #146 export function

* build!: #146 apply exclusion function to Eucalyptus dataset in targets pipeline

Note that this functionality was previously included in the  manuscript

* #146 increment dev version and news before rebuilding package and targets pipeline

* - build!: don't forget to filter the corresponding diversity data after exclusions!

* - build!: fix #146 regenerate yi data after excluding extreme values

* Increment version number to 2.7.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant