Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs in package data regeneration for ManyAnalysts manuscript #148

Merged
merged 14 commits into from
Sep 5, 2024

Conversation

egouldo
Copy link
Owner

@egouldo egouldo commented Sep 5, 2024

only count `mixed_model` after calling `distinct()` on analysis identifier column and `mixed_model` first.

Update argument checking to fail if any id columns not present.

docs: update `@details` section about required id column and add `any_of()` to `@importFrom`
…ues in Zr #144

removed filter for `exclusion_set` == "complete"
…ltiplier threshold for population parameter estimates
…s pipeline

Note that this functionality was previously included in the  manuscript
@egouldo egouldo added bug an unexpected problem or unintended behavior documentation feature a feature request or enhancement breaking change ☠️ API change likely to affect existing code upkeep maintenance, infrastructure, and similar labels Sep 5, 2024
@egouldo egouldo added this to the Respond Reviewer Comments milestone Sep 5, 2024
@egouldo egouldo self-assigned this Sep 5, 2024
@egouldo egouldo merged commit 967852b into main Sep 5, 2024
1 check passed
@egouldo egouldo deleted the manuscript-bugs branch September 5, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code bug an unexpected problem or unintended behavior documentation feature a feature request or enhancement upkeep maintenance, infrastructure, and similar
Projects
None yet
1 participant