Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #88 conditionally apply standardisation to datasets #112

Merged
merged 60 commits into from
Aug 14, 2024

Conversation

egouldo
Copy link
Owner

@egouldo egouldo commented Aug 14, 2024

egouldo added 30 commits August 12, 2024 14:48
- #104 mv `assign_transformation_type()` and `convert_predictions()` out of `standardise_response()` into `back_transform_response_vars_yi()`
- Call `back_transform_response_vars_yi()` in `prepare_response_variables()` for yi workflow (was not being called currently) #104
- #104 keep addition of `param_table` inside `standardise_response()`
- don't return out early (after backtransformation, need to standardise still!) #104
- standardise on the results of backtransformation `out`, if applied, and if not, use `out` prior to backtransformation, and backtransform on original `out` #104
…`standardise_response()`

- incorrect use of pipe operator returned TRUE when one expression eval'd to TRUE, but we want it to return FALSE if *any* exprs eval to FALSE.
…`dat` may or may not have the required `dataset` column.
- don't expect any identifier col other than `id_col` exists
- don't expect `transformation`, or `response_transformation_status` exists
- expect `response_variable_name` exists
- NOTE: dummy function for datasets not selected for standardising is currently applied
- TODO: update dummy function
- TODO: apply functions with map2
- #42 #102 functionalise + document forest plot extraction
- #42 mv plot_forest into pkg and document #102
@egouldo egouldo added this to the Respond Reviewer Comments milestone Aug 14, 2024
@egouldo egouldo added bug an unexpected problem or unintended behavior documentation breaking change ☠️ API change likely to affect existing code upkeep maintenance, infrastructure, and similar labels Aug 14, 2024
@egouldo egouldo self-assigned this Aug 14, 2024
@egouldo egouldo merged commit 42b1e38 into main Aug 14, 2024
1 check passed
@egouldo egouldo deleted the 88-no-euc-standardisation branch August 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change ☠️ API change likely to affect existing code bug an unexpected problem or unintended behavior documentation upkeep maintenance, infrastructure, and similar
Projects
None yet
1 participant