-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #88 conditionally apply standardisation to datasets #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…akagawa (2023)
- #104 mv `assign_transformation_type()` and `convert_predictions()` out of `standardise_response()` into `back_transform_response_vars_yi()` - Call `back_transform_response_vars_yi()` in `prepare_response_variables()` for yi workflow (was not being called currently) #104 - #104 keep addition of `param_table` inside `standardise_response()`
…`standardise_response()` - incorrect use of pipe operator returned TRUE when one expression eval'd to TRUE, but we want it to return FALSE if *any* exprs eval to FALSE.
…dardise_response()`
…`dat` may or may not have the required `dataset` column.
- don't expect any identifier col other than `id_col` exists - don't expect `transformation`, or `response_transformation_status` exists - expect `response_variable_name` exists
- NOTE: dummy function for datasets not selected for standardising is currently applied - TODO: update dummy function - TODO: apply functions with map2
egouldo
added
bug
an unexpected problem or unintended behavior
documentation
breaking change ☠️
API change likely to affect existing code
upkeep
maintenance, infrastructure, and similar
labels
Aug 14, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change ☠️
API change likely to affect existing code
bug
an unexpected problem or unintended behavior
documentation
upkeep
maintenance, infrastructure, and similar
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@examples
tag to correct line /document@importFrom
calls with@import
devtools::document()
,devtools::build_vignettes()
assign_transformation_type()
andconvert_predictions()
out ofstandardise_response()
intoback_transform_response_vars_yi()
- Callback_transform_response_vars_yi()
inprepare_response_variables()
for yi workflow (was not being called currently) prepare back-transformation analysis pipeline needs reorganising - duplicated components #104 - prepare back-transformation analysis pipeline needs reorganising - duplicated components #104 keep addition ofparam_table
insidestandardise_response()
prepare_response_variable()
- don't return out early (after backtransformation, need to standardise still!) prepare back-transformation analysis pipeline needs reorganising - duplicated components #104 - standardise on the results of backtransformationout
, if applied, and if not, useout
prior to backtransformation, and backtransform on originalout
prepare back-transformation analysis pipeline needs reorganising - duplicated components #104convert_predictions()
/standardise_response()
- incorrect use of pipe operator returned TRUE when one expression eval'd to TRUE, but we want it to return FALSE if any exprs eval to FALSE.back_transform_response_vars_yi()
andstandardise_response()
dataset
, not column in input argdat
, asdat
may or may not have the requireddataset
column.id_col
exists - don't expecttransformation
, orresponse_transformation_status
exists - expectresponse_variable_name
exists@imports
call and document new param for new arg inprepare_response_variables()
Ensure euc yi vars not erroneously being back-transformed #88fns
in list-col usingpmap()
approach on entire dataframe, with support of wrapper / parser fun that parses the required variables to eitherstandardise_response()
orprocess_response()
- Upkeep for ManyEcoEvo (2024) #97 delete commentprocess_response()
and replace with...
- roxygen2 documentation for all functions #102 Add@details
section forprocess_response()
and add heading for@details
instandardise_response()
prepare_response_variables()
in targets - only standardise blue tit yi Ensure euc yi vars not erroneously being back-transformed #88