Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small gj refactor #227

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Small gj refactor #227

merged 3 commits into from
Sep 11, 2023

Conversation

oflatt
Copy link
Member

@oflatt oflatt commented Sep 8, 2023

This PR breaks out the core loop of seminaive generic join into a function

@oflatt oflatt requested a review from a team as a code owner September 8, 2023 16:38
@oflatt oflatt requested review from mwillsey and removed request for a team September 8, 2023 16:38
yihozhang
yihozhang reviewed Sep 8, 2023
View reviewed changes
src/gj.rs Outdated Show resolved Hide resolved
@oflatt oflatt requested a review from yihozhang September 10, 2023 01:08
@yihozhang yihozhang merged commit 64e27cd into egraphs-good:main Sep 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihozhang yihozhang yihozhang approved these changes

@mwillsey mwillsey Awaiting requested review from mwillsey mwillsey is a code owner automatically assigned from egraphs-good/egglog-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oflatt @yihozhang