New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add count match and replace string functions #230

Merged

oflatt merged 1 commit into egraphs-good:main from saulshanabrook:add-string-methods

Sep 11, 2023

Member

saulshanabrook commented Sep 9, 2023

This PR adds two new methods for strings, counting the number of occurrences of a substring and replacing a substring.


          Add count match and replace string functions

ef43213

saulshanabrook requested a review from a team as a code owner

September 9, 2023 17:25

saulshanabrook requested review from oflatt and removed request for a team

September 9, 2023 17:25

oflatt approved these changes

View reviewed changes

Member

oflatt left a comment

Looks good to me, won't merge yet so other egglog people can take a look if they want to.

oflatt merged commit f283176 into egraphs-good:main

3 checks passed

saulshanabrook deleted the add-string-methods branch

September 11, 2023 22:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet