Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for matching on rationals #265

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Add support for matching on rationals #265

merged 1 commit into from
Oct 25, 2023

Conversation

saulshanabrook
Copy link
Member

This PR adds numer and denom functions to deconstruct rationals.

Otherwise, I couldn't seem to match on the pieces of them in rules, so this lets you do that now.

@saulshanabrook saulshanabrook requested a review from a team as a code owner October 24, 2023 20:35
@saulshanabrook saulshanabrook requested review from ajpal and removed request for a team October 24, 2023 20:35
oflatt
oflatt approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@oflatt oflatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

@oflatt oflatt merged commit ceed816 into egraphs-good:main Oct 25, 2023
3 checks passed
@saulshanabrook saulshanabrook deleted the match-rational branch October 25, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oflatt oflatt oflatt approved these changes

@ajpal ajpal Awaiting requested review from ajpal ajpal is a code owner automatically assigned from egraphs-good/egglog-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saulshanabrook @oflatt