Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display implementation for DUMMY_SPAN #484

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

RiscInside
Copy link
Contributor

Calling Display on DUMMY_SPAN used to crash the program in debug mode due to underflow. No longer.

@RiscInside RiscInside requested a review from a team as a code owner December 6, 2024 19:15
@RiscInside RiscInside requested review from ezrosent and removed request for a team December 6, 2024 19:15
Copy link
Collaborator

@yihozhang yihozhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link

codspeed-hq bot commented Dec 6, 2024

CodSpeed Performance Report

Merging #484 will not alter performance

Comparing RiscInside:span-display-fix (068b0a9) with main (07fde0e)

Summary

✅ 8 untouched benchmarks

@yihozhang yihozhang merged commit fd933b1 into egraphs-good:main Dec 6, 2024
4 checks passed
@RiscInside RiscInside deleted the span-display-fix branch December 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants