Implement search_for! using functions #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #491 will not alter performanceComparing Summary
|
Avoid unnecessary monomorphization due to macro inlining of closures. This can't always be a method because of double borrows when searching mutably.
DaniPopes
force-pushed
the
search-for-fn
branch
from
5683c8d to
ba4c3ae
Compare
saulshanabrook
approved these changes
Dec 11, 2024
yihozhang
reviewed
Dec 13, 2024
| let Ok(entry) = self.table.find_entry(hash, search_for!(self, hash, inp)) else { | ||
| let Ok(entry) = self | ||
| .table | ||
| .find_entry(hash, search_for(&self.vals, hash, inp)) |
There was a problem hiding this comment.
this can just use self.search_for? (similarly above)
There was a problem hiding this comment.
It would cause a double borrow error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid unnecessary monomorphization due to macro inlining of closures. This can't always be a method because of double borrows when searching mutably.