Make parser extensible and remove resugaring #497
Draft
+320
−934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Fischman
force-pushed
the
sexp-parser
branch
from
5d57428 to
ae61b41
Compare
CodSpeed Performance ReportMerging #497 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Macrosstruct that can be used to extend the parser from external crates. This introduces a name conflict with the existing publicSexpdependency. Since I don't believe that we need this dependency, I have removed it, which breaks all of the code that depends on theToSexptrait, which is basically just resugaring. Since I do not see the value in resugaring I have removed it. However, I am open to having my mind changed on resugaring, in which case I will reimplementDisplayfor the affected structs without usingToSexp.