latest-changes-of-ehsaan-stream #2
Conversation
| @OneToMany(() => Track, (tracks) => tracks.channel) | ||
| tracks: Track; |
There was a problem hiding this comment.
do we need to have tracks with channel?
There was a problem hiding this comment.
Yes we will need it. Every channel will have its separate tracks and we will call them accordingly from the api
| 'Channel not found. Cannot create Tracks', | ||
| HttpStatus.BAD_REQUEST, | ||
| ); | ||
| const newTrack = this.trackRepository.create({ | ||
| ...createTracks, | ||
| channel, | ||
| }); | ||
| return this.trackRepository.save(newTrack); |
There was a problem hiding this comment.
why create new channel? we just need to insert new track with channelId if channel exists
| async login({ name, password }: CreateUserDto) { | ||
| const user = await this.userRepository.findOne({where: {name}}); | ||
| if (!user) { | ||
| throw new HttpException("User not found", HttpStatus.UNAUTHORIZED); | ||
| } | ||
|
|
||
| const areEqual = await comparePassword(password, user.password); | ||
|
|
||
| if (!areEqual) { | ||
| throw new HttpException("Invalid credentials", HttpStatus.UNAUTHORIZED); | ||
| } |
| async createUser(createUserDto: CreateUserDto) { | ||
| try { | ||
| const password = encodePassword(createUserDto.password); | ||
| const newUser = this.userRepository.create({ ...createUserDto, password }); | ||
| await this.userRepository.save(newUser); | ||
| return newUser; | ||
|
|
||
| } catch (error) { | ||
| throw new InternalServerErrorException(); | ||
|
|
||
| } |
There was a problem hiding this comment.
this needs to be protected, cant have users be created.
| export class CreateChannelDto { | ||
| englishName: string; | ||
| arabicName: string; | ||
| channelRoute: string; |
There was a problem hiding this comment.
every channel will have there unique route.
For Example, Moulana Tariq Jameel route will be @MTJ.
https://ehsaan-stream.web.app/channels/@MTJ
We will call channels with this route. It is a unique column.
There was a problem hiding this comment.
ok this is the identifier or handle
not route. change to a different name
| englishName: string; | ||
| arabicName: string; | ||
| channelRoute: string; | ||
| thumbnail: string; |
There was a problem hiding this comment.
Instead of storing the full path of the thumbnail in the database, we store only the thumbnail name. We have implemented a new route that retrieves the saved thumbnail file from the file system (fs) and serves it to the user based on the thumbnail name stored in the database.
Here how it works,
const filePath = join(process.cwd(), 'uploads/thumbnails', channel.thumbnail);
| @@ -0,0 +1,4 @@ | |||
| export class CreateTrackDto { | |||
| name: string; | |||
| src: string; | |||
There was a problem hiding this comment.
We have done same thing for mp3 tracks files what we did for thumbnail files
There was a problem hiding this comment.
In the src column the name of the mp3 file is stored
| name: 'channelId', | ||
| referencedColumnName: 'id', | ||
| }) | ||
| public channel: Channel; |
This PR contains all the latest changes of ehsaan stream- BE. Including migration and seeding