Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angle): support deg text for angle #187

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

christka1
Copy link
Contributor

@christka1 christka1 commented Aug 28, 2024

No description provided.

@christka1 christka1 force-pushed the fix/use-deg-text-for-angle branch from ff382f4 to afbbecd Compare August 28, 2024 13:34
@christka1 christka1 marked this pull request as ready for review August 29, 2024 08:05
@christka1 christka1 requested a review from a team as a code owner August 29, 2024 08:05
Copy link
Member

@Edholm Edholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

easy peasy!

@Edholm
Copy link
Member

Edholm commented Aug 29, 2024

I would perhaps argue that this is a feature though :)

@christka1 christka1 force-pushed the fix/use-deg-text-for-angle branch from afbbecd to 8ec572c Compare August 29, 2024 08:07
@christka1 christka1 changed the title fix(angle): support deg text for angle feat(angle): support deg text for angle Aug 29, 2024
Uses deg text in addition to the current way of
using the degree symbol. It also aligns with
how we use "rad" for radians.
@christka1 christka1 force-pushed the fix/use-deg-text-for-angle branch from 8ec572c to 5b321e5 Compare August 29, 2024 08:14
@christka1 christka1 merged commit dca0058 into master Aug 29, 2024
1 check passed
@christka1 christka1 deleted the fix/use-deg-text-for-angle branch August 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants