Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added a few tests, fixed bugs that those tests turned up, and refactored a thew things on the way #25

Open
wants to merge 19 commits into
base: v2
Choose a base branch
from
Open

added a few tests, fixed bugs that those tests turned up, and refactored a thew things on the way #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7201985
Added tests for more EventValues
DarkStarDS9 Feb 26, 2018
47b2b02
refactored ChangeOfValue
DarkStarDS9 Feb 26, 2018
926c122
Refactored ChangeOfState
DarkStarDS9 Feb 27, 2018
5d1306d
Added ASHRAE Examples F.1.2, F.1.3 and F.1.4
DarkStarDS9 Feb 27, 2018
abae73f
Added ASHRAE Examples F.1.5 and F.1.6
DarkStarDS9 Feb 27, 2018
f26bfac
Added ASHRAE Example F.1.8
DarkStarDS9 Feb 27, 2018
d85aa83
Added ASHRAE Examples F.1.9 to F.1.11
DarkStarDS9 Feb 28, 2018
80eeef5
Split Serialize.Services into smaller parts
DarkStarDS9 Feb 28, 2018
54abdb4
Added ASHRAE Examples F.2.1 and F.2.2
DarkStarDS9 Feb 28, 2018
92ed10a
Added ASHRAE Examples F.3.1 to F.3.8
DarkStarDS9 Feb 28, 2018
8d959c0
Started to move test-data to its own class so that it can be shared
DarkStarDS9 Mar 1, 2018
52669df
Added ASHRAE Examples F.3.9 and F.3.10
DarkStarDS9 Mar 1, 2018
42788cb
Added ASHRAE Examples F.4.1 to F.4.9
DarkStarDS9 Mar 1, 2018
6c1a779
added some back2back tests, fixed issues
DarkStarDS9 Mar 1, 2018
4113a78
covered AlarmAndEventServices
DarkStarDS9 Mar 2, 2018
550819d
covered FileAccessServices
DarkStarDS9 Mar 2, 2018
858fa06
covered ObjectAccessServices
DarkStarDS9 Mar 5, 2018
654fcad
covered RemoteDeviceManagementServices
DarkStarDS9 Mar 5, 2018
2073f10
added a single test for malformed packets
DarkStarDS9 Mar 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions BACnet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
<Compile Include="Base\BacnetAlarmSummaryData.cs" />
<Compile Include="Base\BacnetApplicationTags.cs" />
<Compile Include="Base\BacnetBinaryPv.cs" />
<Compile Include="Base\BacnetObjectPropertyReference.cs" />
<Compile Include="Base\BacnetProgramError.cs" />
<Compile Include="Base\BacnetProgramRequest.cs" />
<Compile Include="Base\BacnetProgramState.cs" />
Expand All @@ -78,9 +79,12 @@
<Compile Include="Base\BacnetDateRange.cs" />
<Compile Include="Base\BacnetDeviceObjectPropertyReference.cs" />
<Compile Include="Base\BacnetError.cs" />
<Compile Include="Base\BacnetWriteAccessSpecification.cs" />
<Compile Include="Base\Enums\EnableDisable.cs" />
<Compile Include="Base\Enums\EnumUtils.cs" />
<Compile Include="Base\EventNotification\EventValues\EventValuesBase.cs" />
<Compile Include="Base\EventNotification\EventValues\ChangeOfLifeSafety.cs" />
<Compile Include="Helpers\FactoryHelper.cs" />
<Compile Include="Base\EventNotification\EventValues\UnsignedRange.cs" />
<Compile Include="Base\EventNotification\EventValues\ChangeOfState.cs" />
<Compile Include="Base\EventNotification\EventValues\OutOfRange.cs" />
Expand Down Expand Up @@ -108,7 +112,6 @@
<Compile Include="Base\BacnetPropertyIds.cs" />
<Compile Include="Base\BacnetPropertyReference.cs" />
<Compile Include="Base\BacnetPropertyValue.cs" />
<Compile Include="Base\BacnetPropertyState.cs" />
<Compile Include="Base\BacnetPtpDisconnectReasons.cs" />
<Compile Include="Base\BacnetPtpFrameTypes.cs" />
<Compile Include="Base\BacnetReadAccessResult.cs" />
Expand Down Expand Up @@ -139,10 +142,15 @@
<Compile Include="Base\Enums\BacnetLimitEnable.cs" />
<Compile Include="Base\Enums\BacnetNotifyTypes.cs" />
<Compile Include="Base\Enums\BacnetCOVTypes.cs" />
<Compile Include="Base\IHasStatusFlags.cs" />
<Compile Include="Helpers\BacnetValuesExtensions.cs" />
<Compile Include="Helpers\StringFormatterExtension.cs" />
<Compile Include="Base\BacnetBvlcV6Functions.cs" />
<Compile Include="Base\BacnetBvlcV6Results.cs" />
<Compile Include="Serialize\Services\AlarmAndEventServices.cs" />
<Compile Include="Serialize\Services\FileAccessServices.cs" />
<Compile Include="Serialize\Services\ObjectAccessServices.cs" />
<Compile Include="Serialize\Services\RemoteDeviceManagementServices.cs" />
<Compile Include="Transport\BacnetTransportBase.cs" />
<Compile Include="Transport\IBacnetSerialTransport.cs" />
<Compile Include="Transport\IBacnetTransport.cs" />
Expand All @@ -167,7 +175,6 @@
<Compile Include="Serialize\MSTP.cs" />
<Compile Include="Serialize\NPDU.cs" />
<Compile Include="Serialize\PTP.cs" />
<Compile Include="Serialize\Services.cs" />
<Compile Include="Storage\DeviceStorage.cs" />
<Compile Include="Storage\Object.cs" />
<Compile Include="Storage\Property.cs" />
Expand Down
2 changes: 2 additions & 0 deletions BACnet.csproj.DotSettings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=base/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=base_005Cenums/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=serialize_005Cnewfolder1/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=serialize_005Cservices/@EntryIndexedValue">True</s:Boolean>
<s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=transport/@EntryIndexedValue">True</s:Boolean>
<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/PLACE_ACCESSORHOLDER_ATTRIBUTE_ON_SAME_LINE_EX/@EntryValue">NEVER</s:String>
<s:Boolean x:Key="/Default/CodeStyle/CodeFormatting/CSharpFormat/WRAP_AFTER_INVOCATION_LPAR/@EntryValue">True</s:Boolean>
Expand Down
1 change: 1 addition & 0 deletions BACnet.sln.DotSettings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=APDU/@EntryIndexedValue">APDU</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=ASHRAE/@EntryIndexedValue">ASHRAE</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=ASN/@EntryIndexedValue">ASN</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=BBMD/@EntryIndexedValue">BBMD</s:String>
<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/Abbreviations/=BVLC/@EntryIndexedValue">BVLC</s:String>
Expand Down
Loading