Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to netstandard2 and new project format #31

Merged
merged 1 commit into from
May 27, 2019
Merged

Update to netstandard2 and new project format #31

merged 1 commit into from
May 27, 2019

Conversation

maikebing
Copy link

No description provided.

@maikebing maikebing mentioned this pull request Feb 21, 2019
@gralin
Copy link
Member

gralin commented Mar 1, 2019

@maikebing thank you for contribution. I will check if everything is ok, especially with the continous integration and merge it soon.

@gralin gralin changed the base branch from v2 to v2-netstandard May 27, 2019 17:25
@gralin gralin merged commit b9d02ae into ela-compil:v2-netstandard May 27, 2019
@JohnnBlade
Copy link

I have been working on a clean version of the BACnet code, and its in .Net Core but can be set to be used in .net Standaard

@JohnnBlade
Copy link

i am porting all of this code to .Net core and refactoring it all, inc naming conventions

@gralin
Copy link
Member

gralin commented May 27, 2019

Hi @JohnnBlade, thanks for the heads up. Are you planning on contributing back to this repo or are you planning on maintaining it as a fork?

@JohnnBlade
Copy link

Hi @JohnnBlade, thanks for the heads up. Are you planning on contributing back to this repo or are you planning on maintaining it as a fork?

Greets Gralin,

I would like that to help out a bit, i just recently found out about BACnet, but when i saw the code and the naming conventions used, i wanted to make it more better, and also refactor and clean up the different coding styles used.

for now i just downloaded this project in zip and started to clean up the whole code, but im not done yet , i do have it on my github.

only thing is that i dont have any BACnet hardware and im testing with software devices instead of real oners so testing is limited for me, but im willing to help out

@gralin
Copy link
Member

gralin commented May 27, 2019

@JohnnBlade great to hear you are interested in contributing, any help is always appreciated! Speaking of current codebase and conventions, please check out this comment to learn more about the history of this project and get the idea why it is how it is: #25 (comment)

One thing I'm afraid is that your huge refactor will be unreviewable and unless you deliver it in a batch of separate PRs, I won't be able to merge with clear conscience 🙈 Do you think this is something you will be able to do? Also, which branch did you download? There is a v2 branch with a lot of contribution from @DarkStarDS9 and there is also an unmerged PR from him (#25) that I would like to include. That codebase is already way better then master. It's my fault that I didn't find enough time after work to maintain this repo but I will try to do better.

@maikebing maikebing deleted the v2 branch May 30, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants