Add createRealmLineage mutation to API
#1179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
LukasKalbertodt
force-pushed
the
better-mount-api
branch
from
768d11d
to
4e62821
Compare
github-actions
bot
removed
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
status:conflicts
This is supposed to make mounting series easier from external scripts. The existing `mountSeries` API is (a) doing a lot of different things and (b) requires the caller to distinguish between what realms already exist and which still need to be created. This new API is idempotent and more convenient. With this, it would be possible to simplify `mountSeries`, but we can't simply break that API since the Admin UI is using it. So we keep it for now. We might add an alternative API in the future.
LukasKalbertodt
force-pushed
the
better-mount-api
branch
from
4e62821
to
9798996
Compare
github-actions
bot
removed
the
status:conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to make mounting series easier from external scripts. The existing
mountSeriesAPI is (a) doing a lot of different things and (b) requires the caller to distinguish between what realms already exist and which still need to be created. This new API is idempotent and more convenient. With this, it would be possible to simplifymountSeries, but we can't simply break that API since the Admin UI is using it. So we keep it for now. We might add an alternative API in the future.@wsmirnow asked for this. Please let me know if this already helps you! You still have to use the
mountSeriesAPI but at least you can always pass[]asnew_realmsby first calling this new API.