Add playlist blocks #1181
Merged
Add playlist blocks #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
status:conflicts
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
removed
the
status:conflicts
github-actions
bot
added
the
status:conflicts
This comment was marked as resolved.
This comment was marked as resolved.
This is mainly to prevent some code duplication for the select component, since playlists and series share basically every aspect with very few exceptions.
This involves several frontend components which are related to the creation and editing of playlist blocks. It features very little original code as these functions and UI elements are already established for other block types. Though a few of the adjustments necessary to make everything work weren't super trivial either.
This needed some tinkering and adapting the "link-within-a-link" approach used in the search item display. For reference, the implemented solution is adapted from (this article)[https://www.sarasoueidan.com/blog/nested-links/]. Most css changes here are made to keep the tab order intact without changing the html structure (i.e. the video item itself getting focus before the nested link).
This was called `opencast_id` before, which was a little misleading since it's not the kind of `opencast_id` used in other places which is typically (but not necessariliy) a uuid but can be any string. The id that is now renamed to `entry_id` however is always a number.
github-actions
bot
removed
the
status:conflicts
These will only show up when a user visits a video page that was linked to from a playlist block. In any other case, either a series block (if applicable) or no block at all is shown, as before.
owi92
force-pushed
the
playlist-blocks
branch
3 times, most recently
from
f92f556
to
4aef78b
Compare
LukasKalbertodt
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #1159 to add the necessary components and adjustments in both back- and frontend to allow creating and editing playlist blocks.
These are already a lot of changes, so in order to limit the scope of this PR and make it somewhat reviewable, a feature still missing is a management area to create, delete and edit playlists themselves (i.e. adding and removing videos).