Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mention "delete" in things "write" access can do #1254

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

LukasKalbertodt
Copy link
Member

@oas777 you mentioned this in an internal issue. Check the "files changed" tab to see what I changed.

@LukasKalbertodt LukasKalbertodt added the changelog:user User facing changes label Oct 1, 2024
@github-actions github-actions bot temporarily deployed to test-deployment-pr1254 October 1, 2024 11:42 Destroyed
@owi92 owi92 merged commit df91940 into elan-ev:master Oct 1, 2024
3 checks passed
@LukasKalbertodt LukasKalbertodt deleted the improve-write-acl-note branch October 1, 2024 13:05
@oas777
Copy link
Collaborator

oas777 commented Oct 1, 2024

I think it's a bit casual to mention "delete" side by side with "change metadata", so I would argue in favour of "löschen (!)", "löschen" or "- und löschen" at the end to highlight this particular right. To normalise my 11pm opinion, feel free to decide this on your own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:user User facing changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants