remove method actually deletes the current implementation #36057
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this updated version of the remove function, instead of updating the TTL of the resource to 0, we directly remove the resource from the
ephemeralStore
using itsRemove
method. This should fix the issue and properly delete the resource from memory.Why is it important?
The original implementation set the TTL of the resource to 0, which retained the resource’s state in memory and made another set operation record in the registry log. This might have been done to optimize the deletion process and delay it until some kind of garbage collection. However, when files are deleted, their states are retained in memory and another set operation record is made in the registry log, which is much larger than the delete operation line. This could potentially cause issues with memory usage and registry log size.
The updated code I provided directly removes the resource from the
ephemeralStore
using itsRemove
method. This should properly delete the resource from memory and avoid making another set operation record in the registry log.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs