Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LVM example to Filebeat file / device ID docs #37959

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Add LVM example to Filebeat file / device ID docs #37959

merged 3 commits into from
Feb 20, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Feb 9, 2024 •
edited
Loading

This updates the "file identity" section on the Filebeat filestream input page to give an explicit example of where filestream should be set to path.

Closes: #34418

screen

@kilfoyle kilfoyle added docs Team:Docs Label for the Observability docs team backport-v8.12.0 Automated backport with mergify labels Feb 9, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 9, 2024
@kilfoyle kilfoyle mentioned this pull request Feb 9, 2024
Closed
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 9, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 8 min 29 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

belimawr
belimawr reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kilfoyle,

That looks great, thank you so much!

I'm just wondering if this should be under "Reading files on network shares and cloud providers" or not.

My understanding is that could happen on any system, not only on cloud VMs.

Maybe moving it to the file_identity section or even putting under the native option to be more explicit that's the only one affected by Device IDs/inodes changing.

@kilfoyle
Copy link
Contributor Author

@belimawr Yeah, that makes perfect sense. Thanks! I've moved the new text to under the native option, in the file_identity section. I've updated the screen capture in the PR description.

@kilfoyle kilfoyle added the backport-v8.13.0 Automated backport with mergify label Feb 14, 2024
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@kilfoyle kilfoyle merged commit 865f70f into elastic:main Feb 20, 2024
31 of 32 checks passed
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
@kilfoyle @mergify
Add LVM example to Filebeat file / device ID docs (#37959)
8cca637 
* Add LVM example to Filebeat file / device ID docs

* Move addition to under 'native' in the file_identity section

(cherry picked from commit 865f70f)
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
@kilfoyle @mergify
Add LVM example to Filebeat file / device ID docs (#37959)
67f3165 
* Add LVM example to Filebeat file / device ID docs

* Move addition to under 'native' in the file_identity section

(cherry picked from commit 865f70f)
This was referenced Feb 20, 2024
Merged
Merged
kilfoyle added a commit that referenced this pull request Feb 20, 2024
@mergify @kilfoyle
Add LVM example to Filebeat file / device ID docs (#37959) (#38069)
5fa24d7 
* Add LVM example to Filebeat file / device ID docs

* Move addition to under 'native' in the file_identity section

(cherry picked from commit 865f70f)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Feb 20, 2024
@mergify @kilfoyle
Add LVM example to Filebeat file / device ID docs (#37959) (#38068)
e1194bf 
* Add LVM example to Filebeat file / device ID docs

* Move addition to under 'native' in the file_identity section

(cherry picked from commit 865f70f)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr approved these changes

Assignees

@kilfoyle kilfoyle

Labels
backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify docs Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Filebeat] Improve documentation about file identifiers/device ID
3 participants
@kilfoyle @elasticmachine @belimawr