Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-action: support check/lint/pre-commit #38175

Merged
merged 13 commits into from
Jun 4, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Mar 4, 2024

Proposed commit message

Further actions

  • Update branch-protection:
    • Add pre-commit / pre-commit

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2024
@mergify mergify bot assigned v1v Mar 4, 2024
Copy link
Contributor

mergify bot commented Mar 4, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 131 min 34 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v marked this pull request as ready for review March 4, 2024 17:27
@v1v v1v requested review from a team as code owners March 4, 2024 17:27
.github/workflows/pre-commit.yml Outdated Show resolved Hide resolved
@botelastic botelastic bot added Team:Automation Label for the Observability productivity team and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 4, 2024
Comment on lines -6 to -7

- repo: https://github.com/elastic/apm-pipeline-library.git
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to support this

@@ -12,11 +12,6 @@ when:
tags: true ## for all the tags
platform: "immutable && ubuntu-22" ## default label for all the stages
stages:
checks:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason these checks were not migrated in #32723

@v1v v1v requested a review from a team as a code owner March 12, 2024 09:05
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 12, 2024

💔 Build Failed

Failed CI Steps

History

cc @v1v

@v1v v1v enabled auto-merge (squash) March 12, 2024 09:31
@v1v v1v added backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify labels Mar 12, 2024
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jenkinsfile Outdated Show resolved Hide resolved
@v1v
Copy link
Member Author

v1v commented Mar 14, 2024

I don't know who has the superpower to merge, but! It will require a couple of further changes afterwards, as noted in the description.

Jenkinsfile Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented May 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature/check-on-gh-actions upstream/feature/check-on-gh-actions
git merge upstream/main
git push upstream feature/check-on-gh-actions

Jenkinsfile Outdated Show resolved Hide resolved
@dliappis dliappis requested a review from alexsapran May 15, 2024 14:51
@dliappis dliappis added the backport-v8.14.0 Automated backport with mergify label May 15, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are moving to BK, I would like to ask if we can split this PR into two smaller ones, one containing only the changes to the .pre-commit-config.yaml and then a follow-up to either try adding it to BK or, if that fails then the GH workflow.

@pazone
Copy link
Contributor

pazone commented Jun 4, 2024

LGTM

@v1v v1v merged commit bef2cc6 into main Jun 4, 2024
10 checks passed
@v1v v1v deleted the feature/check-on-gh-actions branch June 4, 2024 17:48
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit bef2cc6)

# Conflicts:
#	.pre-commit-config.yaml
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
(cherry picked from commit bef2cc6)

# Conflicts:
#	.pre-commit-config.yaml
mergify bot pushed a commit that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants