Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add include_message to the list of Filestream parsers #39654

Merged
merged 1 commit into from
May 22, 2024

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented May 21, 2024

Proposed commit message

Add include_message to the list of Filestream parsers

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

  1. Make sure you have https://github.com/elastic/docs cloned at the same level as Beats
  2. Export $GIT_HOME as the folder where you have cloned docs and beats
  3. Build the docs/start the web server:
    $GIT_HOME/docs/build_docs --respect_edit_url_overrides --doc $GIT_HOME/beats/filebeat/docs/index.asciidoc --resource=$GIT_HOME/beats/x-pack/filebeat/docs --chunk 1 --open
    
  4. Navigate to http://localhost:8000/guide/filebeat-input-filestream.html#_parsers
  5. Ensure include_message is in the list of parsers.
    ## Related issues
    ## Use cases
    ## Screenshots
    ## Logs

@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 21, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 21, 2024
Copy link
Contributor

mergify bot commented May 21, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert requested review from a team, rdner and fearful-symmetry and removed request for a team May 22, 2024 07:07
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up for other reviewers: the parser had been documented in https://www.elastic.co/guide/en/beats/filebeat/8.13/filebeat-input-filestream.html#_include_message before this PR. It was just missing on the list.

@belimawr belimawr merged commit 5036d12 into elastic:main May 22, 2024
18 of 19 checks passed
@belimawr belimawr deleted the fix-filestream-parsers branch May 22, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants