Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.12](backport #40508) [aws] Update max_number_of_messages doc #40513

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 13, 2024

Proposed commit message

This PR is to update the documentation for max_number_of_messages to inform users to keep default 5 for this parameter and use the Balanced or Optimized for Throughput presets in the Performance tuning settings to tune your Elastic Agent performance.

This is a followup change after #40231.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This is an automatic backport of pull request #40508 done by [Mergify](https://mergify.com).

(cherry picked from commit 0567022)

# Conflicts:
#	x-pack/filebeat/docs/inputs/input-aws-s3.asciidoc
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Aug 13, 2024
Copy link
Contributor Author

mergify bot commented Aug 13, 2024

Cherry-pick of 0567022 has failed:

On branch mergify/bp/8.12/pr-40508
Your branch is up to date with 'origin/8.12'.

You are currently cherry-picking commit 0567022433.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/filebeat/docs/inputs/input-aws-s3.asciidoc

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 13, 2024
@botelastic
Copy link

botelastic bot commented Aug 13, 2024

This pull request doesn't have a Team:<team> label.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner August 14, 2024 14:44
@kaiyan-sheng kaiyan-sheng requested review from rdner and mauri870 and removed request for a team August 14, 2024 14:44
@kaiyan-sheng kaiyan-sheng merged commit a1f0362 into 8.12 Aug 15, 2024
11 checks passed
@kaiyan-sheng kaiyan-sheng deleted the mergify/bp/8.12/pr-40508 branch August 15, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant