[vSphere] add triggered alarm to existing metricsets. #40714

niraj-elastic · 2024-09-09T15:37:40Z

Description

Added alert.names field to fetch information related to alert in all the metricsets.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Relates https://github.com/elastic/obs-integration-team/issues/44

mergify · 2024-09-09T15:38:15Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @niraj-elastic? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

ishleenk17 · 2024-09-10T04:00:38Z

@niraj-elastic : Can we please keep this change for just the alarms as we have to do it for all metricsets. It becomes difficult to review otherwise.
Also, please add the sample event.

mergify · 2024-09-10T10:06:55Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_add_alerts_metrics upstream/vsphere_add_alerts_metrics
git merge upstream/main
git push upstream vsphere_add_alerts_metrics

…phere_add_alerts_metrics Conflicts: metricbeat/module/vsphere/fields.go

ishleenk17 · 2024-09-10T18:20:09Z

Please update sample jsons of all the metricsets.

mergify · 2024-09-11T03:53:05Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_add_alerts_metrics upstream/vsphere_add_alerts_metrics
git merge upstream/main
git push upstream vsphere_add_alerts_metrics

…phere_add_alerts_metrics Conflicts: metricbeat/module/vsphere/datastore/datastore.go metricbeat/module/vsphere/host/host.go

mergify · 2024-09-11T11:53:30Z

backport-8.x has been added to help with the transition to the new branch 8.x.

ishleenk17 · 2024-09-11T16:55:13Z

metricbeat/module/vsphere/cluster/cluster.go

+	for _, alarmState := range triggeredAlarmState {
+		var triggeredAlarm triggerdAlarm
+		var alarm mo.Alarm
+		err := pc.RetrieveOne(ctx, alarmState.Alarm, nil, &alarm)


Where is the alarm state being compared to red "critical alarms ?

@ishleenk17 As we discussed yesterday, we will fetch all the triggered alarms and ingest them, filtering will be done in pipeline of kibana.

Are we able to access triggered_alarms.state in the triggered alarms object, if user wants to get only red alarms there?
Can you share here the processor
We will be able to do it in ingest pipeline in Integrations.
Are we mentioning somewhere which processors can they use to achieve the same result in beats ?

Yes i have tried to access triggered_alarm.state and fetch red alarms.

In beats also Processors are supported which can be used to fetch red alarms. user can use something like script processor.

metricbeat/module/vsphere/datastorecluster/_meta/fields.yml

ishleenk17 · 2024-09-11T16:56:49Z

metricbeat/module/vsphere/host/_meta/data.json

+                {
+                  "name": "Host memory usage",
+                  "id": "alarm-4.host-12",
+                  "status": "yellow",


We should list only the critical alarms, yellow ones should not be listed.

We can filleter out yellow ones by using pipeline in kibana. we have kept the yellow ones as well so that in future we don't have to update vshphere metricsets to add yellow alarms if customer requires it.

…-elastic/beats into vsphere_add_alerts_metrics

kush-elastic

LGTM!

ishleenk17 · 2024-09-12T13:49:56Z

Can we update data.json of other metricsets also with dummy values is also fine.
We can use the same format from host for which we got the alarms.

mergify · 2024-09-13T04:33:43Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere_add_alerts_metrics upstream/vsphere_add_alerts_metrics
git merge upstream/main
git push upstream vsphere_add_alerts_metrics

ishleenk17 · 2024-09-13T05:14:45Z

Can we update data.json of other metricsets also with dummy values is also fine. We can use the same format from host for which we got the alarms.

The changes look fine.
We can ad that to future tasks to update alarms in data.json for other metricsets as well.

…phere_add_alerts_metrics Conflicts: metricbeat/module/vsphere/datastore/datastore.go metricbeat/module/vsphere/fields.go metricbeat/module/vsphere/host/host.go metricbeat/module/vsphere/virtualmachine/virtualmachine.go

* add alert names * update host metricset * add alert metrics to all the metricsets * add changelog entry * update data_test * add triggerd alarms * added entity name * mage check --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: Kush Rana <kush.rana@elastic.co> Co-authored-by: harnish-elastic <harnish.chavda@elastic.co> (cherry picked from commit 885a2db) # Conflicts: # metricbeat/module/vsphere/datastore/datastore.go # metricbeat/module/vsphere/datastorecluster/datastorecluster.go # metricbeat/module/vsphere/fields.go # metricbeat/module/vsphere/host/host.go # metricbeat/module/vsphere/virtualmachine/virtualmachine.go

* add alert names * update host metricset * add alert metrics to all the metricsets * add changelog entry * update data_test * add triggerd alarms * added entity name * mage check --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: Kush Rana <kush.rana@elastic.co> Co-authored-by: harnish-elastic <harnish.chavda@elastic.co> (cherry picked from commit 885a2db)

…ricsets. (#40835) * [vSphere] add triggered alarm to existing metricsets. (#40714) * add alert names * update host metricset * add alert metrics to all the metricsets * add changelog entry * update data_test * add triggerd alarms * added entity name * mage check --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: Kush Rana <kush.rana@elastic.co> Co-authored-by: harnish-elastic <harnish.chavda@elastic.co> (cherry picked from commit 885a2db) * Address CI issue --------- Co-authored-by: niraj-elastic <124254029+niraj-elastic@users.noreply.github.com> Co-authored-by: ishleenk17 <ishleen.kaur@elastic.co>

…icsets. (#40812) * [vSphere] add triggered alarm to existing metricsets. (#40714) * add alert names * update host metricset * add alert metrics to all the metricsets * add changelog entry * update data_test * add triggerd alarms * added entity name * mage check --------- Co-authored-by: Niraj Rathod <niraj.rathod@crestdatasys.com> Co-authored-by: Kush Rana <kush.rana@elastic.co> Co-authored-by: harnish-elastic <harnish.chavda@elastic.co> (cherry picked from commit 885a2db) # Conflicts: # metricbeat/module/vsphere/datastore/datastore.go # metricbeat/module/vsphere/datastorecluster/datastorecluster.go # metricbeat/module/vsphere/fields.go # metricbeat/module/vsphere/host/host.go # metricbeat/module/vsphere/virtualmachine/virtualmachine.go * fix existing conflicts * fix changelog entry --------- Co-authored-by: niraj-elastic <124254029+niraj-elastic@users.noreply.github.com> Co-authored-by: Kush Rana <89848966+kush-elastic@users.noreply.github.com> Co-authored-by: Kush Rana <kush.rana@elastic.co>

add alert names

0a294d9

niraj-elastic self-assigned this Sep 9, 2024

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 9, 2024

mergify bot added the backport-v8.x label Sep 10, 2024

niraj-elastic and others added 2 commits September 10, 2024 12:53

Merge branch 'elastic:main' into vsphere_add_alerts_metrics

0c22f11

update host metricset

84f1be3

niraj-crest added 3 commits September 10, 2024 20:07

Merge branch 'main' of https://github.com/niraj-elastic/beats into vs…

ec4f927

…phere_add_alerts_metrics Conflicts: metricbeat/module/vsphere/fields.go

add alert metrics to all the metricsets

80de0ae

add changelog entry

c58257b

niraj-elastic requested review from kush-elastic and ishleenk17 September 10, 2024 15:00

niraj-elastic added enhancement Metricbeat Metricbeat and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 10, 2024

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2024

niraj-elastic added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Sep 10, 2024

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 10, 2024

niraj-elastic marked this pull request as ready for review September 10, 2024 15:06

niraj-elastic requested a review from a team as a code owner September 10, 2024 15:06

update data_test

6759e89

Merge branch 'main' of https://github.com/niraj-elastic/beats into vs…

e74a9ac

…phere_add_alerts_metrics Conflicts: metricbeat/module/vsphere/datastore/datastore.go metricbeat/module/vsphere/host/host.go

mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024

v1v removed the backport-v8.x label Sep 11, 2024

add triggerd alarms

17b531a

Merge branch 'main' into vsphere_add_alerts_metrics

78e3b0b

niraj-elastic changed the title ~~[vSphere] add alert names to existing metricsets.~~ [vSphere] add triggered alarm to existing metricsets. Sep 11, 2024

ishleenk17 reviewed Sep 11, 2024

View reviewed changes

Merge branch 'main' into vsphere_add_alerts_metrics

4506cc4

niraj-elastic requested a review from ishleenk17 September 12, 2024 05:52

niraj-crest added 2 commits September 12, 2024 16:18

added entity name

7dacfe8

Merge branch 'vsphere_add_alerts_metrics' of https://github.com/niraj…

ed87c8e

…-elastic/beats into vsphere_add_alerts_metrics

kush-elastic approved these changes Sep 12, 2024

View reviewed changes

ishleenk17 approved these changes Sep 13, 2024

View reviewed changes

kush-elastic force-pushed the vsphere_add_alerts_metrics branch from 462e997 to 911dbfc Compare September 13, 2024 06:40

mage check

d04d6d4

ishleenk17 merged commit 885a2db into elastic:main Sep 13, 2024
29 checks passed

mergify bot mentioned this pull request Sep 13, 2024

[8.x](backport #40714) [vSphere] add triggered alarm to existing metricsets. #40812

Merged

6 tasks

ishleenk17 added the backport-8.15 Automated backport to the 8.15 branch with mergify label Sep 15, 2024

mergify bot mentioned this pull request Sep 15, 2024

[8.15](backport #40714) [vSphere] add triggered alarm to existing metricsets. #40835

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vSphere] add triggered alarm to existing metricsets. #40714

[vSphere] add triggered alarm to existing metricsets. #40714

niraj-elastic commented Sep 9, 2024 •

edited

Loading

mergify bot commented Sep 9, 2024

ishleenk17 commented Sep 10, 2024

mergify bot commented Sep 10, 2024

ishleenk17 commented Sep 10, 2024

mergify bot commented Sep 11, 2024

mergify bot commented Sep 11, 2024

ishleenk17 Sep 11, 2024

niraj-elastic Sep 12, 2024

ishleenk17 Sep 12, 2024

niraj-elastic Sep 12, 2024

ishleenk17 Sep 11, 2024

niraj-elastic Sep 12, 2024

kush-elastic left a comment

ishleenk17 commented Sep 12, 2024

mergify bot commented Sep 13, 2024

ishleenk17 commented Sep 13, 2024 •

edited

Loading

[vSphere] add triggered alarm to existing metricsets. #40714

[vSphere] add triggered alarm to existing metricsets. #40714

Conversation

niraj-elastic commented Sep 9, 2024 • edited Loading

Description

Checklist

Related issues

mergify bot commented Sep 9, 2024

ishleenk17 commented Sep 10, 2024

mergify bot commented Sep 10, 2024

ishleenk17 commented Sep 10, 2024

mergify bot commented Sep 11, 2024

mergify bot commented Sep 11, 2024

ishleenk17 Sep 11, 2024

Choose a reason for hiding this comment

niraj-elastic Sep 12, 2024

Choose a reason for hiding this comment

ishleenk17 Sep 12, 2024

Choose a reason for hiding this comment

niraj-elastic Sep 12, 2024

Choose a reason for hiding this comment

ishleenk17 Sep 11, 2024

Choose a reason for hiding this comment

niraj-elastic Sep 12, 2024

Choose a reason for hiding this comment

kush-elastic left a comment

Choose a reason for hiding this comment

ishleenk17 commented Sep 12, 2024

mergify bot commented Sep 13, 2024

ishleenk17 commented Sep 13, 2024 • edited Loading

niraj-elastic commented Sep 9, 2024 •

edited

Loading

ishleenk17 commented Sep 13, 2024 •

edited

Loading