Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add debug histograms for s3 object size and events per processed s3 object #40775

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

Kavindu-Dodan
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan commented Sep 11, 2024

Proposed commit message

Fixes #40306 by adding s3_events_per_object & s3_object_size_in_bytes histograms. These histograms provide valuable insights on the size of S3 objects filebeat processed and the number of events produced by each S3 object.

Consider below screenshot,

image

  • Uploads two documents with 15 total logs (10 logs in one and another with 5 logs)
  • See how s3_events_per_object tracks events (logs) per object with max, min and count
  • See how s3_object_size_in_bytes tracks object size with max and min and count

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Run filebeat with AWS S3 connectivity
  • Access debug metrics through http://<http.host>:<http.port>/inputs/?type=aws-s3
  • Observe s3_object_size_in_bytes & s3_events_per_object histograms

Related issues

@Kavindu-Dodan Kavindu-Dodan requested a review from a team as a code owner September 11, 2024 22:31
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 11, 2024
@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@Kavindu-Dodan Kavindu-Dodan added backport-skip Skip notification from the automated backport with mergify and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 11, 2024
@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@Kavindu-Dodan Kavindu-Dodan added Team:obs-ds-hosted-services Label for the Observability Hosted Services team and removed backport-8.x Automated backport to the 8.x branch with mergify labels Sep 11, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 11, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@Kavindu-Dodan Kavindu-Dodan removed the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@elastic elastic deleted a comment from mergify bot Sep 11, 2024
@elastic elastic deleted a comment from mergify bot Sep 11, 2024
@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 11, 2024
@Kavindu-Dodan Kavindu-Dodan removed the backport-8.x Automated backport to the 8.x branch with mergify label Sep 12, 2024
@elastic elastic deleted a comment from mergify bot Sep 12, 2024
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job, lgtm!

@Kavindu-Dodan Kavindu-Dodan added backport-8.x Automated backport to the 8.x branch with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Sep 12, 2024
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
@Kavindu-Dodan Kavindu-Dodan merged commit 8f2c3f9 into elastic:main Sep 13, 2024
20 checks passed
mergify bot pushed a commit that referenced this pull request Sep 13, 2024
…ed s3 object (#40775)

* add debug histograms for s3 object size and events per object

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* changelog entry

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* move changelog to developer next

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

---------

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
(cherry picked from commit 8f2c3f9)
Kavindu-Dodan added a commit that referenced this pull request Sep 13, 2024
…ed s3 object (#40775) (#40819)

* add debug histograms for s3 object size and events per object

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* changelog entry

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

* move changelog to developer next

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>

---------

Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
(cherry picked from commit 8f2c3f9)

Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add message size information into s3-sqs input metrics
3 participants