-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add debug histograms for s3 object size and events per processed s3 object #40775
Merged
Kavindu-Dodan
merged 3 commits into
elastic:main
from
Kavindu-Dodan:feat/add-size-metrics
Sep 13, 2024
Merged
chore: add debug histograms for s3 object size and events per processed s3 object #40775
Kavindu-Dodan
merged 3 commits into
elastic:main
from
Kavindu-Dodan:feat/add-size-metrics
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 11, 2024
mergify
bot
added
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Sep 11, 2024
Kavindu-Dodan
added
backport-skip
Skip notification from the automated backport with mergify
and removed
backport-8.x
Automated backport to the 8.x branch with mergify
labels
Sep 11, 2024
mergify
bot
added
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Sep 11, 2024
Kavindu-Dodan
added
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
and removed
backport-8.x
Automated backport to the 8.x branch with mergify
labels
Sep 11, 2024
botelastic
bot
removed
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Sep 11, 2024
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
mergify
bot
added
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Sep 11, 2024
Kavindu-Dodan
removed
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Sep 11, 2024
mergify
bot
added
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Sep 11, 2024
Kavindu-Dodan
removed
the
backport-8.x
Automated backport to the 8.x branch with mergify
label
Sep 12, 2024
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
Kavindu-Dodan
force-pushed
the
feat/add-size-metrics
branch
from
September 12, 2024 14:13
22d170a
to
786a2b7
Compare
kaiyan-sheng
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job, lgtm!
Kavindu-Dodan
added
backport-8.x
Automated backport to the 8.x branch with mergify
and removed
backport-skip
Skip notification from the automated backport with mergify
labels
Sep 12, 2024
Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co>
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
…ed s3 object (#40775) * add debug histograms for s3 object size and events per object Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * changelog entry Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * move changelog to developer next Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> (cherry picked from commit 8f2c3f9)
3 tasks
Kavindu-Dodan
added a commit
that referenced
this pull request
Sep 13, 2024
…ed s3 object (#40775) (#40819) * add debug histograms for s3 object size and events per object Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * changelog entry Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * move changelog to developer next Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> (cherry picked from commit 8f2c3f9) Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-8.x
Automated backport to the 8.x branch with mergify
Team:obs-ds-hosted-services
Label for the Observability Hosted Services team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Fixes #40306 by adding
s3_events_per_object
&s3_object_size_in_bytes
histograms. These histograms provide valuable insights on the size of S3 objects filebeat processed and the number of events produced by each S3 object.Consider below screenshot,
s3_events_per_object
tracks events (logs) per object with max, min and counts3_object_size_in_bytes
tracks object size with max and min and countChecklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
s3_object_size_in_bytes
&s3_events_per_object
histogramsRelated issues