Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[system/process]: mark module as healthy if metrics are partially filled for single process as well. #40924

Merged
merged 5 commits into from
Oct 8, 2024
Merged

[system/process]: mark module as healthy if metrics are partially filled for single process as well. #40924

merged 5 commits into from
Oct 8, 2024

Conversation

VihasMakwana
Copy link
Contributor

@VihasMakwana VihasMakwana commented Sep 20, 2024 •
edited
Loading

  • Bug

This PR follows #40565. It does the same thing when a single pid is used in config.

Closes elastic/elastic-agent#5555

Testing steps:

  • Build agentbeat from this branch.
  • Place the agentbeat binary under elastic-agent/components
  • Run the elastic agent in unprivileged mode and enabled the system.process dataset for any privileged process.
  • You should see status as healthy.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @VihasMakwana? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify Mergify
Copy link
Contributor

mergify bot commented Sep 20, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Sep 20, 2024
@VihasMakwana VihasMakwana mentioned this pull request Sep 20, 2024
Closed
@VihasMakwana VihasMakwana changed the title DRAFT - [system/process]: mark module as healthy if metrics are partially filled for single process as well. [system/process]: mark module as healthy if metrics are partially filled for single process as well. Sep 30, 2024
@VihasMakwana VihasMakwana marked this pull request as ready for review September 30, 2024 13:10
@VihasMakwana VihasMakwana requested a review from a team as a code owner September 30, 2024 13:10
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Sep 30, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2024
@pierrehilbert
Copy link
Collaborator

@lalit-satapathy it looks like we have MSSQL tests that are starting to fail. Could we have someone from your team to investigate please? And confirm if we can force merge this one (or skip the test) in the meantime.

@lalit-satapathy
Copy link
Contributor

MSSQL

CC: @shmsr

@shmsr shmsr mentioned this pull request Oct 3, 2024
Merged
6 tasks
@shmsr
Copy link
Member

shmsr commented Oct 3, 2024 •
edited
Loading

@pierrehilbert I've found the issue with mssql; fixed in this PR: #41104 (microsoft/mssql-docker#881)

I've asked my team to approve ASAP; I'll merge as soon as CI goes green. If urgent, you can cherry-pick the changes to this branch (current PR) as well.

--

UPDATE: Still breaking in CI. Will check!

--

FIXED: Had to incorporate one more change that I did to fix a similar issue in integrations: elastic/integrations#10899; have pushed the change. Local tests work fine. I hope CI goes green this time.

--

UPDATE: Fixed. Waiting for it to be merged!

@mergify mergify bot mentioned this pull request Oct 4, 2024
Merged
6 tasks
@pierrehilbert
Copy link
Collaborator

Thanks for the update and triggering the testing here again. Looking forward to see the results

@shmsr
Copy link
Member

shmsr commented Oct 4, 2024

Thanks for the update and triggering the testing here again. Looking forward to see the results

All checks passed!

@pierrehilbert
Copy link
Collaborator

Thanks for your help here @shmsr
@faec we will need your review here

@VihasMakwana
Copy link
Contributor Author

Thanks @shmsr!

@pierrehilbert pierrehilbert requested review from leehinman and removed request for AndersonQ October 4, 2024 09:41
This was referenced Oct 7, 2024
Merged
Merged
@VihasMakwana VihasMakwana merged commit dc94114 into elastic:main Oct 8, 2024
31 checks passed
mergify bot pushed a commit that referenced this pull request Oct 8, 2024
@VihasMakwana @mergify
[system/process]: mark module as healthy if metrics are partially fi…
3037165 
…lled for single process as well. (#40924)

* fix: mark module as healthy if metrics are partially filled for single processes

* chore: fix lint

* chore: wrap the error and return

* chore: fix lint

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
(cherry picked from commit dc94114)
@mergify mergify bot mentioned this pull request Oct 8, 2024
Merged
pierrehilbert pushed a commit that referenced this pull request Oct 8, 2024
@mergify @VihasMakwana
[system/process]: mark module as healthy if metrics are partially fi…
591e713 
…lled for single process as well. (#40924) (#41169)

* fix: mark module as healthy if metrics are partially filled for single processes

* chore: fix lint

* chore: wrap the error and return

* chore: fix lint

---------

Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
(cherry picked from commit dc94114)

Co-authored-by: VihasMakwana <121151420+VihasMakwana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonQ AndersonQ AndersonQ left review comments

@leehinman leehinman leehinman approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@VihasMakwana VihasMakwana

Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows agent gets unhealthy on adding Elastic Defend integration.
7 participants
@VihasMakwana @elasticmachine @pierrehilbert @lalit-satapathy @shmsr @AndersonQ @leehinman