Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41014) Fix prometheus imports to match OTel #41055

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 30, 2024

Proposed commit message

Fixes our prometheus go.mod imports to match what prometheus upstream recommends for how to use it as a library.

This aligns our imports to match the OTel collector distribution which prevents the collisions of prometheus modules.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works (test exists)
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc. (not user facing)

Disruptive User Impact

None


This is an automatic backport of pull request #41014 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Sep 30, 2024
@mergify mergify bot requested review from a team as code owners September 30, 2024 20:58
@mergify mergify bot requested review from tetianakravchenko, constanca-m, AndersonQ and VihasMakwana and removed request for a team September 30, 2024 20:58
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 30, 2024
@botelastic
Copy link

botelastic bot commented Sep 30, 2024

This pull request doesn't have a Team:<team> label.

@blakerouse blakerouse merged commit 1fd7b23 into 8.x Oct 1, 2024
141 checks passed
@blakerouse blakerouse deleted the mergify/bp/8.x/pr-41014 branch October 1, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant