Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to fix ga hermit cache #1926

Closed
wants to merge 3 commits into from

Conversation

moukoublen
Copy link
Member

@moukoublen moukoublen commented Feb 13, 2024

Summary of your changes

Screenshot/Data

Related Issues

Fixes: #1175

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Copy link

mergify bot commented Feb 13, 2024

This pull request does not have a backport label. Could you fix it @moukoublen? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented Feb 13, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 39
⬜ Skipped 1

@orestisfl orestisfl changed the title attempt to fix ga hernmit cache attempt to fix ga hermit cache Feb 13, 2024
Copy link
Contributor

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about https://github.com/cashapp/activate-hermit that has a cache option?

@moukoublen
Copy link
Member Author

@orestisfl that was my first thought but we need some extra directories in cache that are not included in https://github.com/cashapp/activate-hermit.

We need (so far):

          ~/.cache/hermit/pkg
          ./.hermit
          ~/.cache/go-build
          ~/go/pkg/
          ~/.cache/pre-commit

This is still draft. I am stiil thinking about the optimal way to separate the caches in order not to get overwritten (because cloudbeat has a lot workflows that run in parallel using the same -or not- cache).

@orestisfl
Copy link
Contributor

Great, thanks. How are we going to handle the case where different items are cached depending on the pipeline? For example, opa pipelines will just initialize opa while go tests will initialize ~/go as well.

@moukoublen
Copy link
Member Author

This is what I meant when I wrote that I am still thinking about the optimal way to separate the caches in order not to get overwritten. Different pipelines run in parallel and might initialize different parts of "cache". (Hermit install at the beginning is the easy part and already implemented. The difficult part are python envs, go pks and pre-commit cache).

This is still wip

@moukoublen
Copy link
Member Author

closed due to this: #2000

@moukoublen moukoublen closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI cache constantly above limit
2 participants