Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws provider name to org scan #2043

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

orouz
Copy link
Collaborator

@orouz orouz commented Mar 18, 2024

Summary of your changes

initializes cloud.NewDataProvider with awsIdentity account so the cloud.provider.name is included

Screenshot/Data

before after
Screenshot 2024-03-18 at 16 01 19 Screenshot 2024-03-18 at 16 00 58

Related Issues

@@ -103,7 +103,7 @@ func (a *AWSOrg) initialize(ctx context.Context, log *logp.Logger, cfg *config.C
return m, nil
}))

return reg, cloud.NewDataProvider(), nil, nil
return reg, cloud.NewDataProvider(cloud.WithAccount(*awsIdentity)), nil, nil
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is needed here -

insertIfNotEmpty(cloudProviderField, a.providerName, event),

@orouz orouz marked this pull request as ready for review March 18, 2024 14:31
@orouz orouz requested a review from a team as a code owner March 18, 2024 14:31
@orouz orouz merged commit 164781a into elastic:main Mar 19, 2024
27 checks passed
mergify bot pushed a commit that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants