Prepare Cloudbeat for AWS Gov cloud #2050
Conversation
|
This pull request does not have a backport label. Could you fix it @kubasobon? 🙏
|
📊 Allure Report - 💚 No failures were reported.
|
internal/flavors/benchmark/aws.go
Outdated
| ) | ||
|
|
||
| awsConfig, awsIdentity, err = a.getIdentity(ctx, cfg) | ||
| // TODO(kuba): Ask when the DefaultRegion is empty. Is there a chance it is |
There was a problem hiding this comment.
This needs to be solved before merging, right?
There was a problem hiding this comment.
Yes, exactly. I would love someone more knowledgable would comment on how CloudConfig.Aws is populated.
There was a problem hiding this comment.
someone more knowledgable would comment on how
CloudConfig.Awsis populated.
I don't qualify as very knowledgable, but afaik this configuration comes from the configuration yaml file + injected via agent.
I don't think overwriting is good idea.
But @amirbenun or @jeniawhite are better suited to explain how it's populated and if it's wise to overwrite it
There was a problem hiding this comment.
@kubasobon @romulets
The configuration comes from the agent and is based on the populated config during the installation of the AWS CSPM integration.
so it appears that the DefaultRegion field is not being populated.
There was a problem hiding this comment.
Perfect, so there is no chance of getting a collision. Thank you.
|
Tested on regular AWS as well: |
Summary of your changes
us-gov-east-1nil pointer dereferenceerrorsScreenshot/Data
Tested in AWS Gov cloud manually.
Related Issues
Fixes https://github.com/elastic/security-team/issues/8681
Checklist
Introducing a new rule?