Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Create Environment] Add new tag and fix delete env script #2070

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

gurevichdmitry
Copy link
Collaborator

Summary of your changes

This PR adds a new tag deployment for the create environment Terraform script.
Additionally, it fixes the delete environment script to handle the case where no GCP deployment exists. Instead of failing, the script now provides a message stating that no GCP deployments need to be deleted.

Screenshot/Data

Related Issues

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

Copy link

mergify bot commented Mar 31, 2024

This pull request does not have a backport label. Could you fix it @gurevichdmitry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@gurevichdmitry gurevichdmitry marked this pull request as ready for review March 31, 2024 13:41
@gurevichdmitry gurevichdmitry requested a review from a team as a code owner March 31, 2024 13:41
Copy link

❌ No tests were run ❌

team = "${var.team}"
project = "${var.project}"
owner = "${var.owner}"
deployment = "${var.deployment_name}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to populate deployment_name in the Github action?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this has already been done here.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Copy link

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

@gurevichdmitry gurevichdmitry merged commit 147ede5 into main Mar 31, 2024
35 checks passed
@gurevichdmitry gurevichdmitry deleted the dg-add-tf-tag-and-fix-delete-env branch March 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants