Skip to content

Commit

Permalink
Stop copying bucket list when doing desc sort (#110439)
Browse files Browse the repository at this point in the history
No need to copy here, the list is freshly allocated for us in 100% of
cases here and we're not copying when sorting either.
  • Loading branch information
original-brownbear authored Jul 3, 2024
1 parent 3d4e113 commit 4cc5996
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,7 @@ public InternalAggregation get() {
}
if (InternalOrder.isKeyDesc(order)) {
// we just need to reverse here...
List<Bucket> reverse = new ArrayList<>(reducedBuckets);
Collections.reverse(reverse);
reducedBuckets = reverse;
Collections.reverse(reducedBuckets);
} else if (InternalOrder.isKeyAsc(order) == false) {
// nothing to do when sorting by key ascending, as data is already sorted since shards return
// sorted buckets and the merge-sort performed by reduceBuckets maintains order.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,7 @@ public InternalAggregation get() {
}
if (InternalOrder.isKeyDesc(order)) {
// we just need to reverse here...
List<Bucket> reverse = new ArrayList<>(reducedBuckets);
Collections.reverse(reverse);
reducedBuckets = reverse;
Collections.reverse(reducedBuckets);
} else if (InternalOrder.isKeyAsc(order) == false) {
// nothing to do when sorting by key ascending, as data is already sorted since shards return
// sorted buckets and the merge-sort performed by reduceBuckets maintains order.
Expand Down

0 comments on commit 4cc5996

Please sign in to comment.