Implement lucene pushdown on ST_DISTANCE for Equality #110348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1deb7b7.
Curiously I was not able to reproduce any difference in behaviour between Lucene (pushdown) and ESQL distance calculation, even when focusing in on same data generated to be on the edge of the quantization boundaries and the haversinDistance boundary.
craigtaverner
added
>non-issue
:Analytics/Geo
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
changed the title
iverase
reviewed
Jul 2, 2024
| distance = comparisonType.eq ? distance : Math.nextUp(distance); | ||
| rewritten.add(new SpatialDisjoint(source, spatialExp, makeCircleLiteral(point, distance, literalExp))); | ||
| } else if (comparisonType.eq) { | ||
| rewritten.add(new SpatialIntersects(source, spatialExp, makeCircleLiteral(point, distance, literalExp))); |
There was a problem hiding this comment.
I was expecting for equality this to be disjoint too?
There was a problem hiding this comment.
forget what I am saying it is fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third PR for ST_DISTANCE pushdown to Lucene, and focuses on distance equality. The previous two PRs:
LessThanandLessThanOrEquals: Implement lucene pushdown on ST_DISTANCE #110102GreaterThanandGreaterThanOrEquals: Implement lucene pushdown on ST_DISTANCE for GT and GTE #110253