Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] Reuse existing TLS setup infrastructure in tests #110358

Merged
merged 1 commit into from
Jul 2, 2024
Merged

[Test] Reuse existing TLS setup infrastructure in tests #110358

merged 1 commit into from
Jul 2, 2024
+9 −31

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Jul 2, 2024

Relates: #109899
Resolves: #110356

@ywangd ywangd added >test Issues or PRs that are addressing/adding tests :Distributed/Network Http and internode communication implementations :Security/TLS SSL/TLS, Certificates v8.15.0 labels Jul 2, 2024
@ywangd ywangd requested a review from mhl-b July 2, 2024 03:07
@ywangd ywangd requested a review from a team as a code owner July 2, 2024 03:07
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team Team:Security Meta label for security team labels Jul 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@ywangd ywangd requested a review from Tim-Brooks July 2, 2024 04:06
jfreden
jfreden approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ywangd
Copy link
Member Author

ywangd commented Jul 2, 2024

@mhl-b @Tim-Brooks Merging this now since it's approved by @jfreden to unblock other work. Happy to take post-merging comments if any. Thanks!

@ywangd ywangd merged commit 94fe32a into elastic:main Jul 2, 2024
15 checks passed
@mhl-b mhl-b mentioned this pull request Jul 3, 2024
Merged
@mhl-b
Copy link
Contributor

mhl-b commented Jul 3, 2024

Thanks @ywangd, test should work just fine with existing certificates, since it only needs a SSL context creation.
I send another cleanup PR #110447

elasticsearchmachine pushed a commit that referenced this pull request Jul 4, 2024
@mhl-b
remove security manager supression (#110447)
e215a2a 
Follow for #110358. We don't need security suppression after Netty's
SelfSignCertificate removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreden jfreden jfreden approved these changes

@mhl-b mhl-b Awaiting requested review from mhl-b

@Tim-Brooks Tim-Brooks Awaiting requested review from Tim-Brooks

Assignees
No one assigned
Labels
:Distributed/Network Http and internode communication implementations :Security/TLS SSL/TLS, Certificates Team:Distributed Meta label for distributed team Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Many tests failing when testing with fips
4 participants
@ywangd @elasticsearchmachine @mhl-b @jfreden