[Inference API] Prevent inference endpoints from being deleted if they are referenced by semantic text #110399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by a semantic text field
elasticsearchmachine
added
needs:triage
maxhniebergall
added
>enhancement
:ml
|
Pinging @elastic/ml-core (Team:ML) |
|
Hi @maxhniebergall, I've created a changelog YAML for you. |
maxhniebergall
added
the
auto-merge
…tic/elasticsearch into semanticTextDeleteInference
Mikep86
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Thanks for the quick work here! I think we should take a second pass and consider whether we want to call out semantic text specifically in method names and error messages. We may add inference_id to other field types in the future (such as dense_vector or sparse_vector).
...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/utils/SemanticTextInfoExtractor.java
Outdated
Show resolved
Hide resolved
...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/utils/SemanticTextInfoExtractor.java
Outdated
Show resolved
Hide resolved
...ugin/core/src/main/java/org/elasticsearch/xpack/core/ml/utils/SemanticTextInfoExtractor.java
Outdated
Show resolved
Hide resolved
| "properties": { | ||
| "inference_field": { | ||
| "type": "semantic_text", | ||
| "inference_id": "%s" |
There was a problem hiding this comment.
Nit: indentation is off here
...e-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java
Outdated
Show resolved
Hide resolved
carlosdelest
reviewed
Jul 3, 2024
...e-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java
Outdated
Show resolved
Hide resolved
...in/java/org/elasticsearch/xpack/inference/action/TransportDeleteInferenceEndpointAction.java
Outdated
Show resolved
Hide resolved
davidkyle
reviewed
Jul 3, 2024
...c/main/java/org/elasticsearch/xpack/core/inference/action/DeleteInferenceEndpointAction.java
Show resolved
Hide resolved
Co-authored-by: David Kyle <david.kyle@elastic.co> Co-authored-by: Carlos Delgado <6339205+carlosdelest@users.noreply.github.com>
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/inference/action/DeleteInferenceEndpointAction.java
maxhniebergall
commented
Jul 3, 2024
...resources/rest-api-spec/test/inference/50_semantic_text_query_inference_endpoint_changes.yml
Outdated
Show resolved
Hide resolved
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on #109123