Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stack monitoring mapping for apm-server metrics #110568

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Update stack monitoring mapping for apm-server metrics #110568

merged 3 commits into from
Jul 10, 2024

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Jul 7, 2024 •
edited
Loading

Update stack monitoring template for .monitoring-beats-mb to include latest apm-server monitoring metrics

All stack monitoring apm-server metrics references should be intact:

carson@carson-elastic:~/projects/kibana$ grep --include \*.ts -r 'beats_stats.metrics.apm-server.' x-pack/plugins/monitoring | cut -d"'" -f2 | cut -d'.' -f4- | sort | uniq | wc -l
29
carson@carson-elastic:~/projects/kibana$ grep --include \*.ts -r 'beats_stats.metrics.apm-server.' x-pack/plugins/monitoring | cut -d"'" -f2 | cut -d'.' -f4- | sort | uniq | xargs -I {} grep {} /home/carson/projects/elasticsearch/x-pack/plugin/core/template-resources/src/main/resources/monitoring-beats-mb.json | wc -l
29

To avoid breaking stack monitoring UI, although beat.stats.apm_server.server.response.errors.concurrency is unused and is not present in apm-server stats, it is manually kept in the mapping. Without this fix it would be 29, 28.

Part of elastic/apm-server#13475

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.

@carsonip carsonip changed the title Update stack monitoring apm-server metrics Update stack monitoring mapping for apm-server metrics Jul 7, 2024
@carsonip carsonip mentioned this pull request Jul 9, 2024
Closed
@carsonip carsonip force-pushed the stack-monitoring-apm-server-metrics branch from 610d820 to eac4d91 Compare July 9, 2024 16:52
@carsonip carsonip force-pushed the stack-monitoring-apm-server-metrics branch from eac4d91 to 901a90c Compare July 9, 2024 16:53
@carsonip carsonip marked this pull request as ready for review July 9, 2024 17:10
@carsonip carsonip requested a review from a team as a code owner July 9, 2024 17:10
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jul 9, 2024
@carsonip carsonip mentioned this pull request Jul 9, 2024
Draft
10 tasks
klacabane
klacabane approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@klacabane klacabane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klacabane klacabane added the Team:Data Management Meta label for data/management team label Jul 10, 2024
@elasticsearchmachine elasticsearchmachine removed the Team:Data Management Meta label for data/management team label Jul 10, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jul 10, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jul 10, 2024
@carsonip carsonip added the auto-backport Automatically create backport pull requests when merged label Jul 10, 2024
@carsonip carsonip merged commit 2fb6c80 into elastic:main Jul 10, 2024
15 checks passed
carsonip added a commit to carsonip/elasticsearch that referenced this pull request Jul 10, 2024
@carsonip
Update stack monitoring mapping for apm-server metrics (elastic#110568)
c989858 
Update stack monitoring template for .monitoring-beats-mb to include latest apm-server monitoring metrics. All stack monitoring apm-server metrics references in kibana should be intact. To avoid breaking stack monitoring UI, although beat.stats.apm_server.server.response.errors.concurrency is unused and is not present in apm-server stats, it is manually kept in the mapping.

(cherry picked from commit 2fb6c80)
@carsonip carsonip mentioned this pull request Jul 10, 2024
Merged
@carsonip
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.15

Questions ?

Please refer to the Backport tool documentation

@carsonip carsonip mentioned this pull request Jul 10, 2024
Closed
9 tasks
carsonip added a commit that referenced this pull request Jul 18, 2024
@carsonip
Update stack monitoring mapping for apm-server metrics (#110568) (#11…
8f9d06b 
…0687)

Update stack monitoring template for .monitoring-beats-mb to include latest apm-server monitoring metrics. All stack monitoring apm-server metrics references in kibana should be intact. To avoid breaking stack monitoring UI, although beat.stats.apm_server.server.response.errors.concurrency is unused and is not present in apm-server stats, it is manually kept in the mapping.

(cherry picked from commit 2fb6c80)
@lkts lkts mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klacabane klacabane klacabane approved these changes

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Monitoring >enhancement Team:Data Management Meta label for data/management team v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonip @elasticsearchmachine @klacabane