Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type ECS normalization #159

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Correct SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type ECS normalization #159

merged 3 commits into from
Nov 4, 2024

Conversation

renini
Copy link
Contributor

@renini renini commented Jun 26, 2024

The event.type: stop is not ECS compliant, event.type: end is.

Modified 'stop' to 'end' for the following audit events:

  • SERVICE_STOP
  • DAEMON_ABORT
  • DAEMON_END

@cla-checker-service CLA Checker Service
Copy link

cla-checker-service bot commented Jun 26, 2024 •
edited
Loading

💚 CLA has been signed

@renini renini changed the title Fix ECS event.type compliancy Modified SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type to be ECS compliant Jun 26, 2024
@renini renini changed the title Modified SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type to be ECS compliant Fix SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type ECS normalization Jun 26, 2024
@renini renini marked this pull request as draft June 26, 2024 17:53
@renini renini marked this pull request as ready for review June 26, 2024 17:57
@renini renini changed the title Fix SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type ECS normalization Correct SERVICE_STOP, DAEMON_ABORT, DAEMON_END event.type ECS normalization Jun 26, 2024
@renini
Copy link
Contributor Author

renini commented Jul 7, 2024

Also reported as issue #157

@andrewkroh
Copy link
Member

/test

@andrewkroh andrewkroh added the bug label Nov 4, 2024
@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@andrewkroh andrewkroh requested a review from a team November 4, 2024 19:27
@andrewkroh andrewkroh merged commit 33356aa into elastic:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renini @andrewkroh @elasticmachine