Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set SOCK_CLOEXEC on socket #165

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

frezbo
Copy link
Contributor

@frezbo frezbo commented Nov 1, 2024

Set SOCK_CLOEXEC when creating the socket to avoid leaking file descriptors.

Copy link

cla-checker-service bot commented Nov 1, 2024

💚 CLA has been signed

@andrewkroh andrewkroh added the needs_cla User must sign the Elastic Contributor License before review. label Nov 1, 2024
Set `SOCK_CLOEXEC` when creating the socket to avoid leaking file
descriptors.

Signed-off-by: Noel Georgi <git@frezbo.dev>
@frezbo frezbo force-pushed the chore/prevent-file-descriptor-leaks branch from b49f992 to 69e202d Compare November 2, 2024 05:39
@andrewkroh andrewkroh removed the needs_cla User must sign the Elastic Contributor License before review. label Nov 4, 2024
@andrewkroh andrewkroh requested a review from a team November 4, 2024 13:40
nicholasberlin
nicholasberlin previously approved these changes Nov 4, 2024
@andrewkroh
Copy link
Member

/test

@andrewkroh
Copy link
Member

/test

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@andrewkroh andrewkroh merged commit 1df86e7 into elastic:main Nov 4, 2024
3 checks passed
@andrewkroh
Copy link
Member

Thanks @frezbo

@frezbo frezbo deleted the chore/prevent-file-descriptor-leaks branch November 4, 2024 16:24
frezbo added a commit to frezbo/talos that referenced this pull request Nov 4, 2024
Update `go-auditlib` with fix from elastic/go-libaudit#165

Signed-off-by: Noel Georgi <git@frezbo.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants