Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix uninstall warning about current directory #1368

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix uninstall warning about current directory #1368

merged 2 commits into from
Oct 7, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Oct 7, 2024

This fixes the warning about running the elastic-agent uninstall to indicate that the command shouldn't be run from the directory where agent is installed. This appears in the command reference and the uninstall instructions page.

Closes: #1364
Rel: https://github.com/elastic/sdh-beats/issues/5224#issuecomment-2391715465

Screenshot 2024-10-07 at 2 12 05 PM

@kilfoyle kilfoyle requested a review from a team as a code owner October 7, 2024 18:13
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 7, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

karenzone
karenzone approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 4185605 into elastic:main Oct 7, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
@kilfoyle @mergify
Fix uninstall warning about current directory (#1368)
276f66a 
* Fix uninstall warning about current dir

* fixup

(cherry picked from commit 4185605)
@mergify mergify bot mentioned this pull request Oct 7, 2024
Merged
mergify bot pushed a commit that referenced this pull request Oct 7, 2024
@kilfoyle @mergify
Fix uninstall warning about current directory (#1368)
5c563dd 
* Fix uninstall warning about current dir

* fixup

(cherry picked from commit 4185605)
@mergify mergify bot mentioned this pull request Oct 7, 2024
Merged
kilfoyle added a commit that referenced this pull request Oct 7, 2024
@mergify @kilfoyle
Fix uninstall warning about current directory (#1368) (#1369)
0147e12 
* Fix uninstall warning about current dir

* fixup

(cherry picked from commit 4185605)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Oct 7, 2024
@mergify @kilfoyle
Fix uninstall warning about current directory (#1368) (#1370)
b788e09 
* Fix uninstall warning about current dir

* fixup

(cherry picked from commit 4185605)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman approved these changes

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
backport-8.x backport-8.15
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix instructions for uninstalling agent
3 participants
@kilfoyle @karenzone @michel-laterman