Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update providers_default_disable #884

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

eyalkraft
Copy link
Contributor

Update docs following elastic/elastic-agent#4166

Copy link

github-actions bot commented Feb 4, 2024

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Feb 4, 2024

This pull request does not have a backport label. Could you fix it @eyalkraft? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@eyalkraft eyalkraft marked this pull request as ready for review February 4, 2024 20:16
@eyalkraft eyalkraft requested a review from a team as a code owner February 4, 2024 20:16
kilfoyle
kilfoyle previously approved these changes Feb 5, 2024
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @eyalkraft. This looks great!
I'll just wait for the associated code PR merge before merging this one.

update the flag name to agent.providers.initial_default and reverse its value
@eyalkraft
Copy link
Contributor Author

Thanks @kilfoyle! I think we're ready

@kilfoyle kilfoyle merged commit f5ba20b into elastic:main Feb 6, 2024
4 checks passed
@kilfoyle
Copy link
Contributor

kilfoyle commented Feb 6, 2024

Perfect. Thanks again @eyalkraft and welcome to this repo! :-)

@eyalkraft eyalkraft deleted the patch-1 branch February 6, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants