-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Apache] Rename apache2.error.integration to apache.error.module #9822
Conversation
Shouldn't this be |
Because the field in the apache.error dataset is Sorry for the overloaded terms :D. Hope it makes sense |
@herrBez Makes sense. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for someone else from my team as well to give a +1 on this.
@herrBez LGTM. You will also have to update the package version in |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @herrBez |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Package apache - 1.17.2 containing this change is available at https://epr.elastic.co/search?package=apache |
Proposed commit message
Rename
apache2.error.integration
toapache.error.module
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
apache2.module.error
toapache.module.error
beats#39481Screenshots