Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Apache] Rename apache2.error.integration to apache.error.module #9822

Merged
merged 3 commits into from
May 9, 2024

Conversation

herrBez
Copy link
Contributor

@herrBez herrBez commented May 9, 2024

Proposed commit message

Rename apache2.error.integration to apache.error.module

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@herrBez herrBez added the bug Something isn't working, use only for issues label May 9, 2024
@herrBez herrBez requested a review from a team as a code owner May 9, 2024 07:17
@shmsr
Copy link
Member

shmsr commented May 9, 2024

Shouldn't this be apache2.error.integration to apache.error.integration? Why module?

@herrBez
Copy link
Contributor Author

herrBez commented May 9, 2024

Because the field in the apache.error dataset is apache.error.module. This field represents the Apache Module (https://httpd.apache.org/docs/2.4/mod/core.html#errorlogformat), it has nothing to do with Elastic integrations and should be the same of the Beats apache.error dataset):

https://github.com/elastic/integrations/blob/main/packages/apache/data_stream/error/elasticsearch/ingest_pipeline/default.yml#L21

Sorry for the overloaded terms :D. Hope it makes sense

@shmsr
Copy link
Member

shmsr commented May 9, 2024

@herrBez Makes sense. Thanks.

Copy link
Member

@shmsr shmsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for someone else from my team as well to give a +1 on this.

@devamanv
Copy link
Contributor

devamanv commented May 9, 2024

@herrBez LGTM. You will also have to update the package version in manifest.yml. This is needed for the CI checks to pass.

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @herrBez

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@herrBez herrBez merged commit f398bad into elastic:main May 9, 2024
5 checks passed
@elasticmachine
Copy link

Package apache - 1.17.2 containing this change is available at https://epr.elastic.co/search?package=apache

@andrewkroh andrewkroh added the Integration:apache Apache HTTP Server label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working, use only for issues Integration:apache Apache HTTP Server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants