Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_endpoint: clarify supported HMAC header format #9935

Merged
merged 1 commit into from
May 26, 2024
Merged

http_endpoint: clarify supported HMAC header format #9935

merged 1 commit into from
May 26, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 22, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added documentation Improvements or additions to documentation enhancement New feature or request bugfix Pull request that fixes a bug issue Integration:http_endpoint Custom HTTP Endpoint Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels May 22, 2024
@efd6 efd6 self-assigned this May 22, 2024
@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review May 22, 2024 07:50
@efd6 efd6 requested a review from a team as a code owner May 22, 2024 07:50
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Will this doc change also goes into the input? https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-http_endpoint.html#_hmac_header?

@efd6
Copy link
Contributor Author

efd6 commented May 26, 2024

That is in elastic/beats/pull/39655.

@efd6 efd6 merged commit 6887c9e into elastic:main May 26, 2024
5 checks passed
@elasticmachine
Copy link

Package http_endpoint - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=http_endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
bugfix Pull request that fixes a bug issue documentation Improvements or additions to documentation enhancement New feature or request Integration:http_endpoint Custom HTTP Endpoint Logs Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @kcreddy