Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: 8.15 release notes workaround ref to set system property #16665

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

yaauie
Copy link
Member

@yaauie yaauie commented Nov 12, 2024

Release notes

[rn: skip] (it'd be too self-referential)

What does this PR do?

Workaround documented in #16661 should reference config/jvm.options, not config/jvm.properties 🤦

Why is it important/What is the impact to the user?

Give them a useful workaround for a known issue.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice catch

@jsvd jsvd merged commit effb814 into 8.15 Nov 12, 2024
6 checks passed
@jsvd
Copy link
Member

jsvd commented Nov 12, 2024

@logstashmachine backport 8.16

@jsvd
Copy link
Member

jsvd commented Nov 12, 2024

@logstashmachine backport 8.x

@jsvd jsvd deleted the yaauie-jvm-options branch November 12, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants