Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the Playwright version from the package.json #101

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

elchininet
Copy link
Owner

To run the end-to-end tests we execute Playwright using a spcific Docker tag. To know the docker tag that we need to use, we read the Playwright Docker image tag from a file placed in the root of the project. This provokes that everytime @dependabot creates a pull request updating the @playwright/test package, tests fail because the Playwright Docker image is outdated.

In this pull request, we read the Playwright version from the same package.json and in this way, we can remove the necessity of having the .playwright_docker_version at all.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling c8f308e on get_playwright_version_from_package_json
into a24b5e9 on master.

@elchininet elchininet merged commit a8093ab into master Sep 8, 2024
2 checks passed
@elchininet elchininet deleted the get_playwright_version_from_package_json branch September 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants