Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update squirrel windows to 2.0.1 #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

beyondkmp
Copy link
Contributor

@beyondkmp beyondkmp commented Jul 26, 2024

These files were copied from the vendor folder in this archive: https://github.com/electron/windows-installer/archive/refs/tags/v5.4.0.zip.

@mmaietta
Copy link
Collaborator

Do we need to upload all items from the vendor directory from the git ref?

@beyondkmp
Copy link
Contributor Author

beyondkmp commented Jul 26, 2024

From the windows-installer source code, it appears that all of these are used. We are currently using windows-installer directly, so I suggest uploading all of them.

@beyondkmp
Copy link
Contributor Author

@mmaietta Can you help merge this in?

@mmaietta
Copy link
Collaborator

mmaietta commented Aug 23, 2024

@beyondkmp how do we perform a release of this to Github tagged release (post-merge) for this updated toolset? Maybe we can chat further via discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants