Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add options.binName #78

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add options.binName #78

wants to merge 1 commit into from

Conversation

fcastilloec
Copy link
Collaborator

@fcastilloec fcastilloec commented Jul 22, 2020

I've been playing with the idea of switching to using reverse DNS for the name of my apps. When using any of the installers based on this module, if I set options.name to a reverse-DNS name, this also affects the symlink created by it.
This might not always be the preferred behavior, so perhaps introducing a new option to set the name of the binary symlink might be a good idea.
The new option defaults to the same values as options.name, so this shouldn't break anything. We will have to update desktop.ejs for -debian and -redhat (perhaps other modules too?) to use the new option in the Exec= field.

Currently, I've named it binName but I'm not set on the name, other ideas could be: symlink, symlinkName, or binarySymlink

Helpful when options.name follows reverse DNS
@fcastilloec fcastilloec requested a review from malept July 22, 2020 21:48
@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #78   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          210       210           
=========================================
  Hits           210       210           
Impacted Files Coverage Δ
src/defaults.js 100.00% <ø> (ø)
src/installer.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b67d21e...3c02d8c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant