fix: fix bug in filesystem.insertLink #300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
reviewed
Jan 31, 2024
.gitignore
Outdated
| @@ -8,3 +8,4 @@ | |||
| .node-version | |||
| npm-debug.log | |||
| .idea | |||
| .vscode | |||
There was a problem hiding this comment.
This change seems to be unrelated to the fix
There was a problem hiding this comment.
Sorry for my mistake. I just removed it in 07a14a8
chore: bump electronjs/node in .circleci/config.yml to 2.2.0 Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> fix: fix bug in filesystem.insertLink
jrainlau
force-pushed
the
bugfix/fix-symlink-error
branch
from
4f57777
to
07a14a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In MacOS, if I run
asar.createPackage()to pack a folder into.asar, which contains "symlink", it would get wrong after I runasar.extractAll()from the generated.asar.Let's look at this Beyond Compare result:
The folder in left is the origin one, and the folder in right was generated by using
asar.extractAll()from the origin one's.asar( folderLeft --> folderLeft.asar --> folderRight).Inside the left folder, file Resources were pointed to
Versions/Current/Resources, but the same file inside the right folder were pointed toVersions/A/Resources, it's wrong.