Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support Apple Development/Distribution identities #230

Closed

Conversation

sethlu
Copy link
Contributor

@sethlu sethlu commented Jul 7, 2020

Follow up to the feature request #227

Following the introduction of "Apple Development" and "Apple Distribution" signing identities, we can extend the existing auto-discovery to support these identities:

  • Targeting inside the Mac App Store
    • For development: Try Apple Development, then Mac Developer
    • For distribution: Try Apple Distribution, then 3rd Party Mac Developer Application
  • Targeting outside the Mac App Store
    • Always try Developer ID Application for development/distribution

Closing #183 for now, since there isn't much complain using Developer ID Application for both development and distribution of apps outside the Mac App Store.

Updated findIdentitiesAsync to accept a list of identities
@sethlu sethlu changed the title Support Apple Development/Distribution identities feat: Support Apple Development/Distribution identities Jul 7, 2020
@sethlu
Copy link
Contributor Author

sethlu commented Jul 7, 2020

@mahnunchik Sorry about the wait. If you have the recent signing identities on your end, can you help test if this PR works? Thanks in advance!

@mahnunchik
Copy link

@sethlu I may confirm it works but for signing .pkg the certificate 3rd Party Mac Developer Installer is still selected.

@sethlu
Copy link
Contributor Author

sethlu commented Jul 15, 2020

@mahnunchik Thanks for testing the changes!

I don't think it's documented whether the Apple Distribution certificate applies to signing the installer package? (Ref: https://help.apple.com/xcode/mac/current/#/dev3a05256b8) Therefore I didn't modify the app flattening script to use the more recent certificate 🤔

@mahnunchik
Copy link

@sethlu let's try to push this feature to production ;)

@MarshallOfSound
Copy link
Member

Conflicting with the rewrite, if this change is still applicable please raise a new pull request. Apologies for the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants