Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Codesign issue when app name has spaces #238

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

lcheunglci
Copy link

I created an issue: #237

I believe this was caused by not having the escape character when the codesign command string was being constructed; therefore, causing the codesign command to fail when codesigning the executable e.g. App name.app/Contents/MacOS/App name

I was able to successfully codesign with electron-osx-sign with the change. I hope this resolves issues that others may have run into because their electron app product name has spaces.

@lcheunglci lcheunglci changed the title Fix issue with spaces in the app name fix: Codesign issue when app name has spaces Oct 14, 2020
@lcheunglci lcheunglci marked this pull request as draft October 15, 2020 00:10
@lcheunglci lcheunglci marked this pull request as ready for review October 15, 2020 00:40
@lcheunglci
Copy link
Author

lcheunglci commented Feb 20, 2022

I was merging the newer changes into my fork since I've made this PR. I see that the sign.js has been replaced with sign.ts. While, I was re-applying the changes from merging, I was going to improve string replace for the space character with the escape character to _opts.app using regex (https://stackoverflow.com/questions/44738314/escape-a-space-in-a-file-path-in-node-js) but realized, that with typescript the _opts i.e. SignOption is read-only, so this approach won't work. Perhaps, the more appropriate way is to update the documentation in the README.md that app with space is not supported and throw an exception during the validation in the util.ts in the validateOptsApp so it won't run into an error during the mac codesign process. Let me know if that approach is preferred and I'll make a commit to the README.md and util.ts instead.

@erickzhao erickzhao self-assigned this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants