fix(flat): use pkgbuild to bundle pre/postinstall scripts
#282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzhao
changed the title
flat
erickzhao
reviewed
Jun 13, 2024
3 tasks
erickzhao
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
This seems to work out of the box for me with the following setup erickzhao/maker-pkg-test@4a8f4c9
Also confirmed that the current version of osx-sign doesn't work as expected.
erickzhao
changed the title
flatpkgbuild to bundle pre/postinstall scripts
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 8, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--scriptsshould go topkgbuildin order for preinstall and postinstall script to work. So the singleproductbuildcommand has to be separated intopkgbuildandproductbuild.I am not sure if the
--scriptsinproductbuildhas any practical use. Might need to add an new option if need to retain the--scriptsfor bothproductbuildandpkgbuild