feat: add Use deep flag 😋 #240 #303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a lightweight solution for #240 issue. By adding the optional parameter
useDeepFlagtoOnlySignOptionsto meet the needs of some people to add thecodesign --deepidentification, and configure the default value tofalseand explain the possible impact of this parameter in README. I think this should be an acceptable to most people. If you have any questions, please reply. I look forward to promoting this problem ⭐️.Related links:
#267
#231
#229
Many predecessors have encountered this problem and tried to discuss and solve it clearly. Thank them for their work 👏.
fixed #240
cc @sethlu @MarshallOfSound